Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update the Simplified Chinese documents, or at least set an indicator to tell readers the documents are out of date #57039

Closed
code4lala opened this issue Aug 8, 2022 · 7 comments · Fixed by tensorflow/docs-l10n#609
Assignees
Labels
comp:lite TF Lite related issues stat:awaiting response Status - Awaiting response from author TFLiteGpuDelegate TFLite Gpu delegate issue type:docs-bug Document issues

Comments

@code4lala
Copy link

code4lala commented Aug 8, 2022

Click to expand!

Issue Type

Documentation Bug

Source

source

Tensorflow Version

NA

Custom Code

No

OS Platform and Distribution

NA

Mobile device

NA

Python version

NA

Bazel version

NA

GCC/Compiler version

NA

CUDA/cuDNN version

NA

GPU model and memory

NA

Current Behaviour?

https://www.tensorflow.org/lite/performance/gpu_advanced?hl=zh-cn#android_cc

bazel build -c opt --config android_arm64 tensorflow/lite/delegates/gpu:gl_delegate # for static library
bazel build -c opt --config android_arm64 tensorflow/lite/delegates/gpu:libtensorflowlite_gpu_gl.so # for dynamic library

https://www.tensorflow.org/lite/performance/gpu_advanced?hl=en-us#android_cc

bazel build -c opt --config android_arm64 tensorflow/lite/delegates/gpu:delegate # for static library
bazel build -c opt --config android_arm64 tensorflow/lite/delegates/gpu:libtensorflowlite_gpu_delegate.so # for dynamic library

I read documents in all 20 languages but only the Simplified Chinese version is out of date, and it doesn't have even an indicator to tell me that it is out of date.

The old version library, gl_delegate, its header gl_delegate.h shows

ABSL_DEPRECATED("Use TfLiteGpuDelegateV2Create defined in delegate.h instead.")
TFL_CAPI_EXPORT TfLiteDelegate* TfLiteGpuDelegateCreate(
    const TfLiteGpuDelegateOptions* options);

Standalone code to reproduce the issue

NA

Relevant log output

NA
@google-ml-butler google-ml-butler bot added type:bug Bug type:docs-bug Document issues labels Aug 8, 2022
@mohantym mohantym added comp:lite TF Lite related issues TFLiteGpuDelegate TFLite Gpu delegate issue and removed type:bug Bug labels Aug 8, 2022
@mohantym
Copy link
Contributor

mohantym commented Aug 9, 2022

@code4lala !
Thanks for pointing it out.
@sachinprasadhs !
Could you look at this doc-bug.
Thank you!

@sachinprasadhs
Copy link
Contributor

I have created the pull request by making code changes, once the changes reflect in the master, feel free to add few more language specific changes here https://gitlocalize.com/tensorflow/docs-l10n

@sachinprasadhs sachinprasadhs added the awaiting PR merge awaiting PR merge label Aug 9, 2022
@sachinprasadhs
Copy link
Contributor

@code4lala , The linked PR has been merged, could you please close the issue. Thanks!

@sachinprasadhs sachinprasadhs added stat:awaiting response Status - Awaiting response from author and removed awaiting PR merge awaiting PR merge labels Aug 10, 2022
@code4lala
Copy link
Author

@sachinprasadhs Thanks for your help! But the content in the Simplified Chinese documents is still the old one, how long will it take effect?

@google-ml-butler google-ml-butler bot removed the stat:awaiting response Status - Awaiting response from author label Aug 11, 2022
@sachinprasadhs
Copy link
Contributor

It will take few days to take effect, but there will be one more update with the translation with the description as well apart from the code changes submitted in the above PR.

@sachinprasadhs
Copy link
Contributor

Document is now updated with the latest code and information inline with the english version. Could you please verify here https://www.tensorflow.org/lite/performance/gpu_advanced?hl=zh-cn#android_cc and close the issue. Thanks!

@sachinprasadhs sachinprasadhs added the stat:awaiting response Status - Awaiting response from author label Aug 17, 2022
@code4lala
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:lite TF Lite related issues stat:awaiting response Status - Awaiting response from author TFLiteGpuDelegate TFLite Gpu delegate issue type:docs-bug Document issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants