Add IsScalar / IsVector (rank) checks to input min/max tensors for Fa… #57440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keQuantWithMinMaxVarsPerChannelGradientOp and FakeQuantWithMinMaxVarsGradientOp. PiperOrigin-RevId: 462542629
mihaimaruseac
requested changes
Aug 25, 2022
tensorflow/python/kernel_tests/quantization_ops/quantization_ops_test.py
Outdated
Show resolved
Hide resolved
|
Also, this one has a conflict to resolve. |
…#57440 Co-authored-by: Mihai Maruseac <mihaimaruseac@google.com>
mihaimaruseac
approved these changes
Aug 25, 2022
mihaimaruseac
deleted the
cherrypick-f3cf67ac5705f4f04721d15e485e192bb319feed-on-r2.8
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…keQuantWithMinMaxVarsPerChannelGradientOp and FakeQuantWithMinMaxVarsGradientOp.
PiperOrigin-RevId: 462542629