Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TfLite: adds generate-pc.sh #58586

Merged
merged 3 commits into from Dec 19, 2022
Merged

Conversation

drah
Copy link
Contributor

@drah drah commented Nov 15, 2022

This change adds the generate-pc.sh file for generating the
tensorflowlite.pc that can be used by pkg-config.
This is useful for the platforms that depend on libtensorflowlite.so
instead of the libtensorflow.so.

This change adds the generate-pc.sh file for generating the
tensorflowlite.pc that can be used by pkg-config.
This is useful for the platforms that depend on libtensorflowlite.so
instead of the libtensorflow.so.
@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Nov 15, 2022
@gbaned gbaned added the comp:lite TF Lite related issues label Nov 15, 2022
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Nov 15, 2022
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Nov 15, 2022
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Nov 16, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Nov 16, 2022
@yishuangP
Copy link
Contributor

Hi @terryheo, could you also help take a look?

@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 16, 2022
@terryheo
Copy link
Member

@drah I'm not familiar with pkg-config. Could you elaborate how it is used?

@drah
Copy link
Contributor Author

drah commented Nov 16, 2022

@drah I'm not familiar with pkg-config. Could you elaborate how it is used?

Thanks Terry,

For example,
./generate-pc.sh --version 2.8.0, and there will be a file called tensorflowlite.pc created.
It should be moved to the <path/to/pkgconfig> directory, for example /usr/lib/pkgconfig

And then we can run pkg-config like:
PKG_CONFIG_PATH=<path/to/pkgconfig> pkg-config tensorflowlite --libs --cflags
This will give something like
-I/usr/include/tensorflow -ltensorflowlite

@afq984
Copy link

afq984 commented Nov 17, 2022

my 2c: I think we should reuse https://github.com/tensorflow/tensorflow/blob/master/tensorflow/c/generate-pc.sh instead of duplicating the shell code a separate file in lite/ (thesorflow_cc is not in the cc directory either)

@drah
Copy link
Contributor Author

drah commented Nov 17, 2022

Thanks afq984 for the comment.
I think it's for c version tensorflow. This one should be for tensorflowlite only.

@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Nov 17, 2022

Name: TensorFlowLite
Version: ${TF_VERSION}
Description: Library for computation using data flow graphs for scalable machine learning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's TF description. For TFLite, let's use this.
"Library for deploying models on mobile, microcontrollers and other edge devices."

@gbaned gbaned removed the awaiting review Pull request awaiting review label Nov 18, 2022
@gbaned gbaned requested a review from terryheo November 23, 2022 17:56
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Nov 23, 2022
Copy link
Member

@terryheo terryheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Nov 29, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Nov 29, 2022
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Dec 9, 2022
@copybara-service copybara-service bot merged commit f3631d2 into tensorflow:master Dec 19, 2022
@drah drah deleted the tflite_generate_pc branch December 19, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:lite TF Lite related issues ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

7 participants