build: fix CMake rules for the MHLOTOSATransforms target #59019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A consumer of the MHLOTOSATransforms library (mhlo_tosa_opt.cc) calls the `registerTosaPrepareMhloPassPass()` function, but this function is absent from the MHLOTOSATransforms library since the source file (prepare_mhlo.cc) that contains the function is not included when building the library target. Additionally, prepare_mhlo.cc calls the `populateGeneralDotOpLoweringPatterns()` function, but the library (MhloPasses) that contains this function is not linked when compiling prepare_mhlo.cc. This patch adds the necessary build rules to fix the above problems.
jpienaar
approved these changes
Dec 29, 2022
google-ml-butler
bot
added
kokoro:force-run
copybara-service bot
pushed a commit
to tensorflow/mlir-hlo
that referenced
this pull request
Dec 30, 2022
Imported from GitHub PR tensorflow/tensorflow#59019 A consumer of the MHLOTOSATransforms library (mhlo_tosa_opt.cc) calls the `registerTosaPrepareMhloPassPass()` function, but this function is absent from the MHLOTOSATransforms library since the source file (prepare_mhlo.cc) that contains the function is not included when building the library target. Additionally, prepare_mhlo.cc calls the `populateGeneralDotOpLoweringPatterns()` function, but the library (MhloPasses) that contains this function is not linked when compiling prepare_mhlo.cc. This patch adds the necessary build rules to fix the above problems. Copybara import of the project: -- 5ff6dbff54a5c06d29f7d21bb12448fc4a5f1dcc by Ashay Rane <ashay@users.noreply.github.com>: build: fix CMake rules for the MHLOTOSATransforms target A consumer of the MHLOTOSATransforms library (mhlo_tosa_opt.cc) calls the `registerTosaPrepareMhloPassPass()` function, but this function is absent from the MHLOTOSATransforms library since the source file (prepare_mhlo.cc) that contains the function is not included when building the library target. Additionally, prepare_mhlo.cc calls the `populateGeneralDotOpLoweringPatterns()` function, but the library (MhloPasses) that contains this function is not linked when compiling prepare_mhlo.cc. This patch adds the necessary build rules to fix the above problems. Merging this change closes #59019 PiperOrigin-RevId: 498630526
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Dec 30, 2022
Imported from GitHub PR tensorflow/tensorflow#59019 A consumer of the MHLOTOSATransforms library (mhlo_tosa_opt.cc) calls the `registerTosaPrepareMhloPassPass()` function, but this function is absent from the MHLOTOSATransforms library since the source file (prepare_mhlo.cc) that contains the function is not included when building the library target. Additionally, prepare_mhlo.cc calls the `populateGeneralDotOpLoweringPatterns()` function, but the library (MhloPasses) that contains this function is not linked when compiling prepare_mhlo.cc. This patch adds the necessary build rules to fix the above problems. Copybara import of the project: -- 5ff6dbff54a5c06d29f7d21bb12448fc4a5f1dcc by Ashay Rane <ashay@users.noreply.github.com>: build: fix CMake rules for the MHLOTOSATransforms target A consumer of the MHLOTOSATransforms library (mhlo_tosa_opt.cc) calls the `registerTosaPrepareMhloPassPass()` function, but this function is absent from the MHLOTOSATransforms library since the source file (prepare_mhlo.cc) that contains the function is not included when building the library target. Additionally, prepare_mhlo.cc calls the `populateGeneralDotOpLoweringPatterns()` function, but the library (MhloPasses) that contains this function is not linked when compiling prepare_mhlo.cc. This patch adds the necessary build rules to fix the above problems. Merging this change closes #59019 PiperOrigin-RevId: 498630526
This was referenced Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A consumer of the MHLOTOSATransforms library (mhlo_tosa_opt.cc) calls
the
registerTosaPrepareMhloPassPass()function, but this function isabsent from the MHLOTOSATransforms library since the source file
(prepare_mhlo.cc) that contains the function is not included when
building the library target.
Additionally, prepare_mhlo.cc calls the
populateGeneralDotOpLoweringPatterns()function, but the library(MhloPasses) that contains this function is not linked when compiling
prepare_mhlo.cc.
This patch adds the necessary build rules to fix the above problems.