Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leaks in xla::HloProfileTest #59034

Merged
merged 1 commit into from Dec 30, 2022
Merged

Fix memory leaks in xla::HloProfileTest #59034

merged 1 commit into from Dec 30, 2022

Conversation

rbaranchuk-capgemini
Copy link
Contributor

Leaks were detected by AddressSanitizer

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Dec 28, 2022
@google-ml-butler google-ml-butler bot requested a review from r4nt December 28, 2022 17:22
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Dec 28, 2022
mihaimaruseac
mihaimaruseac reviewed Dec 28, 2022
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, but note that there was a comment saying this was an intentional leak

@rbaranchuk-capgemini
Copy link
Contributor Author

LG, but note that there was a comment saying this was an intentional leak

Yes, I've noted that, but couldn't see any signs in the code that it has to be leaked

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Dec 28, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Dec 28, 2022
@gbaned gbaned added the comp:xla XLA label Dec 29, 2022
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Dec 29, 2022
copybara-service bot pushed a commit to openxla/xla that referenced this pull request Dec 30, 2022
@rbaranchuk-capgemini
PR #59034: Fix memory leaks in xla::HloProfileTest
e5acdc1 
Imported from GitHub PR tensorflow/tensorflow#59034

Leaks were detected by AddressSanitizer
Copybara import of the project:

--
5013cfcc9ae7cc43df4ecbca494bceb367775fc0 by Roman Baranchuk <roman.baranchuk@capgemini.com>:

Fix memory leaks in xla::HloProfileTest

Merging this change closes #59034

PiperOrigin-RevId: 498621296
@copybara-service copybara-service bot merged commit ff0085a into tensorflow:master Dec 30, 2022
PR Queue automation moved this from Assigned Reviewer to Merged Dec 30, 2022
@rbaranchuk-capgemini rbaranchuk-capgemini deleted the xla-hlo-test branch January 9, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@r4nt r4nt Awaiting requested review from r4nt

Assignees

@gbaned gbaned

Labels
awaiting review Pull request awaiting review comp:xla XLA ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rbaranchuk-capgemini @mihaimaruseac @kokoro-team @gbaned