Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMD-ZENDNN] Modifications to support ZenDNN mempool optimizations #59071

Merged
merged 2 commits into from Jan 7, 2023

Conversation

aadwived
Copy link
Contributor

@aadwived aadwived commented Jan 2, 2023

  • ZenDNN mempool optimizations utilizes pre-allocated buffers with TF_Tensor.
  • Hence, amount of allocated TF_Tensor bytes can be greater than or equal to requested bytes by the Op execution.

Authors:
Aakar Dwivedi ( aakar.dwivedi@amd.com )
Avinash-Chandra Pandey ( avinash-chandra.pandey@amd.com )
Chandra Kumar Ramasamy ( chandrakumar.ramasamy@amd.com )
Savan Anadani ( savan.anadani@amd.com )

Signed-off-by: Aakar Dwivedi Aakar.Dwivedi@amd.com

- ZenDNN mempool optimizations utilizes pre-allocated buffers with TF_Tensor.
- Hence, amount of allocated TF_Tensor bytes can be greater than or equal to requested bytes by the Op execution.

Authors:
  Aakar Dwivedi ( aakar.dwivedi@amd.com )
  Avinash-Chandra Pandey ( avinash-chandra.pandey@amd.com )
  Chandra Kumar Ramasamy ( chandrakumar.ramasamy@amd.com )
  Savan Anadani ( savan.anadani@amd.com )

Signed-off-by: Aakar Dwivedi <Aakar.Dwivedi@amd.com>
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jan 2, 2023
@aadwived
Copy link
Contributor Author

aadwived commented Jan 2, 2023

/cc @penpornk

@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jan 3, 2023
@gbaned gbaned requested a review from penpornk January 3, 2023 06:51
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Jan 3, 2023
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

tensorflow/python/lib/core/ndarray_tensor.cc Outdated Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Jan 5, 2023
Co-authored-by: Penporn Koanantakool <38085909+penpornk@users.noreply.github.com>
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick changes!

PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Jan 5, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 5, 2023
@penpornk penpornk removed the awaiting review Pull request awaiting review label Jan 5, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 5, 2023
@copybara-service copybara-service bot merged commit fadee6b into tensorflow:master Jan 7, 2023
PR Queue automation moved this from Approved by Reviewer to Merged Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants