Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixedunigram assert #59096

Merged
merged 2 commits into from Jan 5, 2023
Merged

Fixedunigram assert #59096

merged 2 commits into from Jan 5, 2023

Conversation

bhack
Copy link
Contributor

@bhack bhack commented Jan 4, 2023

Fixes: #59076

@bhack
Migrate asserts to status handling
6ebe63c 
Introduce SetDistributionSampler with Status
@bhack
Fix memory leak
24f39d7
@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Jan 4, 2023
@bhack bhack mentioned this pull request Jan 4, 2023
Merged
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 4, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 4, 2023
@gbaned gbaned added prtype:bugfix PR to fix a bug comp:core issues related to core part of tensorflow labels Jan 5, 2023
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jan 5, 2023
@copybara-service copybara-service bot merged commit 548964d into tensorflow:master Jan 5, 2023
PR Queue automation moved this from Assigned Reviewer to Merged Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cantonios cantonios cantonios approved these changes

Assignees

@gbaned gbaned

Labels
comp:core issues related to core part of tensorflow prtype:bugfix PR to fix a bug ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue created for Rollback of PR #58358: Fix unigram assert
4 participants
@bhack @cantonios @kokoro-team @gbaned