Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects DNNL_VERSION_MINOR set in mkldnn_acl.BUILD #59141

Conversation

nSircombe
Copy link
Contributor

PR #57842 neglected to update the oneDNN version in mkldnn_acl.BUILD to match the version set in workspace2.bzl

PR tensorflow#57842
neglected to update the oneDNN version in mkldnn_acl.BUILD to
match the version set in workspace2.bzl
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jan 6, 2023
@nSircombe
Copy link
Contributor Author

@penpornk - a very minor fix. Something I missed when I raised #57842

Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 9, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 9, 2023
@gbaned gbaned added the comp:mkl MKL related issues label Jan 9, 2023
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jan 9, 2023
copybara-service bot pushed a commit to openxla/xla that referenced this pull request Jan 11, 2023
Imported from GitHub PR tensorflow/tensorflow#59141

PR tensorflow/tensorflow#57842 neglected to update the oneDNN version in mkldnn_acl.BUILD to match the version set in workspace2.bzl
Copybara import of the project:

--
464d2a9b0bdfe6c26bfc4a10924e2b9b9a8dbf58 by Nathan John Sircombe <nathan.sircombe@arm.com>:

Corrects DNNL_VERION_MINOR set in mkldnn_acl.BUILD

PR tensorflow/tensorflow#57842
neglected to update the oneDNN version in mkldnn_acl.BUILD to
match the version set in workspace2.bzl

Merging this change closes #59141

PiperOrigin-RevId: 501167789
copybara-service bot pushed a commit to google/tsl that referenced this pull request Jan 11, 2023
Imported from GitHub PR tensorflow/tensorflow#59141

PR tensorflow/tensorflow#57842 neglected to update the oneDNN version in mkldnn_acl.BUILD to match the version set in workspace2.bzl
Copybara import of the project:

--
464d2a9b0bdfe6c26bfc4a10924e2b9b9a8dbf58 by Nathan John Sircombe <nathan.sircombe@arm.com>:

Corrects DNNL_VERION_MINOR set in mkldnn_acl.BUILD

PR tensorflow/tensorflow#57842
neglected to update the oneDNN version in mkldnn_acl.BUILD to
match the version set in workspace2.bzl

Merging this change closes #59141

PiperOrigin-RevId: 501167789
@copybara-service copybara-service bot merged commit 9524a63 into tensorflow:master Jan 11, 2023
PR Queue automation moved this from Assigned Reviewer to Merged Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:mkl MKL related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants