[mhlo] fix build rules for the MhloPasses target #59219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MhloPasses library, which contains code from symbolic_shape_optimization.cc, refers to `ShapeComponentAnalysis::GetValueInfo()`, which is defined in shape_component_analysis.cc, which is a part of the MhloAnalysis target. However, the CMake rules for building MhloPasses do not add MhloAnalysis as a dependency, causing undefined reference errors in downstream targets. As an ancillary change, this patch also removes the MhloAnalysis dependency in the rule for building mlir-hlo-opt, since the now-fixed dependency in MhloPasses carries over to the mlir-hlo-opt target.
burmako
approved these changes
Jan 19, 2023
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
This was referenced Jan 30, 2023
copybara-service bot
pushed a commit
to tensorflow/mlir-hlo
that referenced
this pull request
Jan 31, 2023
Imported from GitHub PR tensorflow/tensorflow#59219 The MhloPasses library, which contains code from symbolic_shape_optimization.cc, refers to `ShapeComponentAnalysis::GetValueInfo()`, which is defined in shape_component_analysis.cc, which is a part of the MhloAnalysis target. However, the CMake rules for building MhloPasses do not add MhloAnalysis as a dependency, causing undefined reference errors in downstream targets. As an ancillary change, this patch also removes the MhloAnalysis dependency in the rule for building mlir-hlo-opt, since the now-fixed dependency in MhloPasses carries over to the mlir-hlo-opt target. Copybara import of the project: -- 55f8182265d21bea83e507e655af04096ebc6c6b by Ashay Rane <ashay@users.noreply.github.com>: [mhlo] fix build rules for the MhloPasses target The MhloPasses library, which contains code from symbolic_shape_optimization.cc, refers to `ShapeComponentAnalysis::GetValueInfo()`, which is defined in shape_component_analysis.cc, which is a part of the MhloAnalysis target. However, the CMake rules for building MhloPasses do not add MhloAnalysis as a dependency, causing undefined reference errors in downstream targets. As an ancillary change, this patch also removes the MhloAnalysis dependency in the rule for building mlir-hlo-opt, since the now-fixed dependency in MhloPasses carries over to the mlir-hlo-opt target. Merging this change closes #59219 PiperOrigin-RevId: 505985133
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Jan 31, 2023
Imported from GitHub PR tensorflow/tensorflow#59219 The MhloPasses library, which contains code from symbolic_shape_optimization.cc, refers to `ShapeComponentAnalysis::GetValueInfo()`, which is defined in shape_component_analysis.cc, which is a part of the MhloAnalysis target. However, the CMake rules for building MhloPasses do not add MhloAnalysis as a dependency, causing undefined reference errors in downstream targets. As an ancillary change, this patch also removes the MhloAnalysis dependency in the rule for building mlir-hlo-opt, since the now-fixed dependency in MhloPasses carries over to the mlir-hlo-opt target. Copybara import of the project: -- 55f8182265d21bea83e507e655af04096ebc6c6b by Ashay Rane <ashay@users.noreply.github.com>: [mhlo] fix build rules for the MhloPasses target The MhloPasses library, which contains code from symbolic_shape_optimization.cc, refers to `ShapeComponentAnalysis::GetValueInfo()`, which is defined in shape_component_analysis.cc, which is a part of the MhloAnalysis target. However, the CMake rules for building MhloPasses do not add MhloAnalysis as a dependency, causing undefined reference errors in downstream targets. As an ancillary change, this patch also removes the MhloAnalysis dependency in the rule for building mlir-hlo-opt, since the now-fixed dependency in MhloPasses carries over to the mlir-hlo-opt target. Merging this change closes #59219 PiperOrigin-RevId: 505985133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MhloPasses library, which contains code from
symbolic_shape_optimization.cc, refers to
ShapeComponentAnalysis::GetValueInfo(), which is defined inshape_component_analysis.cc, which is a part of the MhloAnalysis target.
However, the CMake rules for building MhloPasses do not add MhloAnalysis
as a dependency, causing undefined reference errors in downstream
targets.
As an ancillary change, this patch also removes the MhloAnalysis
dependency in the rule for building mlir-hlo-opt, since the now-fixed
dependency in MhloPasses carries over to the mlir-hlo-opt target.