Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linaro:ARM_CI] Limit the version of h5py that is allowed to prevent ftb #59430

Merged
merged 1 commit into from Jan 25, 2023
Merged

[Linaro:ARM_CI] Limit the version of h5py that is allowed to prevent ftb #59430

merged 1 commit into from Jan 25, 2023

Conversation

elfringham
Copy link
Contributor

No description provided.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jan 24, 2023
@github-actions github-actions bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 24, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 24, 2023
@elfringham elfringham changed the title Limit the version of h5py that is allowed to prevent ftb [Linaro:ARM_CI] Limit the version of h5py that is allowed to prevent ftb Jan 24, 2023
@gbaned gbaned removed the ready to pull PR ready for merge process label Jan 24, 2023
@elfringham
Copy link
Contributor Author

@penpornk This should fix ARM_CI pipeline

@elfringham elfringham mentioned this pull request Jan 24, 2023
Merged
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jan 24, 2023
@gbaned gbaned requested a review from penpornk January 24, 2023 10:35
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Jan 24, 2023
penpornk
penpornk approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jan 24, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 24, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 24, 2023
penpornk
penpornk reviewed Jan 24, 2023
View reviewed changes
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitins17 Is there a way to limit the constraint to just aarch64? Or are you okay with applying the limit on all platforms?

@penpornk penpornk removed the ready to pull PR ready for merge process label Jan 24, 2023
@elfringham
Copy link
Contributor Author

@penpornk @nitins17 I am working on an alternative fix that will not add a constraint to h5py but will instead allow h5py to be built by the ARM_CI docker container. ie it will fix the hdf5 dependency. This will take maybe a couple of hours to confirm working though.

@github-actions github-actions bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jan 24, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 24, 2023
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label Jan 24, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jan 24, 2023
@nitins17
Copy link
Member

nitins17 commented Jan 24, 2023 •
edited

LGTM, thanks Andrew!

There seem to be tests that fail with ImportError: cannot import name 'estimator_export' from 'tensorflow.python.util.tf_export'. This is likely due to 3837d0f. Rebuilding the Dockerfile to get the latest version of tf-estimator-nightly should fix it.

@copybara-service copybara-service bot merged commit 185b29d into tensorflow:master Jan 25, 2023
PR Queue automation moved this from Approved by Reviewer to Merged Jan 25, 2023
@elfringham elfringham deleted the h5py_limit branch January 26, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penpornk penpornk penpornk approved these changes

@nitins17 nitins17 nitins17 approved these changes

Assignees

@nitins17 nitins17

@penpornk penpornk

@gbaned gbaned

Labels
awaiting review Pull request awaiting review ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@elfringham @nitins17 @penpornk @kokoro-team @gbaned