Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XLA] Support big-endian in numpy-style type descriptor #59532

Merged
merged 1 commit into from Feb 3, 2023

Conversation

kiszk
Copy link
Contributor

@kiszk kiszk commented Feb 3, 2023

This PR supports big-endian byte order in numpy-style type descriptor. This order is determined by the order of a machine to build xla library.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Feb 3, 2023
@google-ml-butler google-ml-butler bot requested a review from r4nt February 3, 2023 04:56
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Feb 3, 2023
@gbaned gbaned added the comp:xla XLA label Feb 3, 2023
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Feb 3, 2023
@gbaned gbaned requested a review from d0k February 3, 2023 09:05
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Feb 3, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 3, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 3, 2023
copybara-service bot pushed a commit to openxla/xla that referenced this pull request Feb 3, 2023
Imported from GitHub PR tensorflow/tensorflow#59532

This PR supports [big-endian byte order](https://numpy.org/doc/stable/reference/arrays.dtypes.html#specifying-and-constructing-data-types) in numpy-style type descriptor. This order is determined by the order of a machine to build xla library.
Copybara import of the project:

--
7473b4dca0ef7349d1834209512576ce89460095 by Kazuaki Ishizaki <ishizaki@jp.ibm.com>:

support big-endian for numpy type descriptor

Merging this change closes #59532

PiperOrigin-RevId: 506909050
@copybara-service copybara-service bot merged commit 296e989 into tensorflow:master Feb 3, 2023
PR Queue automation moved this from Approved by Reviewer to Merged Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Pull request awaiting review comp:xla XLA ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants