Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checking on the quantized limits for tosa.clamp #59708

Merged
merged 1 commit into from Feb 24, 2023
Merged

Add checking on the quantized limits for tosa.clamp #59708

merged 1 commit into from Feb 24, 2023

Conversation

Jerry-Ge
Copy link
Contributor

The original request: #58288 (comment)

This is the 1st patch for review. I will cleanup everything else after the 1st round of review.

Jerry

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Feb 16, 2023
@Jerry-Ge
Copy link
Contributor Author

cc @eric-k256 @rsuderman

@github-actions github-actions bot added the kokoro:force-run Tests on submitted change label Feb 16, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 16, 2023
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Feb 16, 2023
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Feb 16, 2023
@github-actions github-actions bot added the kokoro:force-run Tests on submitted change label Feb 22, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 22, 2023
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Feb 23, 2023
@Jerry-Ge
Add checking on the quantized limits for tosa.clamp
36476f3 
Signed-off-by: Jerry Ge <jerry.ge@arm.com>
@github-actions github-actions bot added the kokoro:force-run Tests on submitted change label Feb 24, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 24, 2023
@Jerry-Ge
Copy link
Contributor Author

There is actually no implementation of the dtype.isUnsigned() Reference . Simply using getStorageTypeMin/Max for much cleaner implementation.

Jerry

@copybara-service copybara-service bot merged commit 1c7f0d0 into tensorflow:master Feb 24, 2023
PR Queue automation moved this from Reviewer Requested Changes to Merged Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsuderman rsuderman rsuderman requested changes

Assignees

@gbaned gbaned

Labels
awaiting review Pull request awaiting review size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jerry-Ge @rsuderman @kokoro-team @gbaned