Add MLIR side effects to tf.XlaCallModule.
#60643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `jax2tf` native serialization, the StableHLO module embedded in `tf.XlaCallModule` may contain `stablehlo.custom_call` calling TF host callback functions. In this case, the `stablehlo.custom_call`s will be lowered to `stablehlo.send` and `stablehlo.recv`, so `tf.XlaCallModule` has `TF_SendSideEffect` and `TF_RecvSideEffect`. This CL 1. replaces the `Pure` trait with `MemoryEffects` trait in the automatically generated `tf.XlaCallModule` op's definition. 2. sets `isStateful` in `XlaCallModule`'s op declaration. 2. updates TF side effect analysis to recursively analyze the TF host callback functions called by `tf.XlaCallModule`. PiperOrigin-RevId: 533635753
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
PiperOrigin-RevId: 533666635
PiperOrigin-RevId: 533666642
Updates LLVM usage to match [aa144fbeaf21](llvm/llvm-project@aa144fbeaf21) PiperOrigin-RevId: 533717007
PiperOrigin-RevId: 533744471
…pile time. PiperOrigin-RevId: 533750651
Updates LLVM usage to match [f7e2678bb706](llvm/llvm-project@f7e2678bb706) PiperOrigin-RevId: 533763275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces updates to the
tf.XlaCallModuleop in order to supportjax2tfnative serialization. Thetf.XlaCallModuleop contains the StableHLO module, which may involve calling TF host callback functions throughstablehlo.custom_call. To enable proper functionality, the following modifications were made:The
Puretrait in the automatically generatedtf.XlaCallModuleop's definition has been replaced with theMemoryEffectstrait.The
isStatefulflag has been set in the op declaration ofXlaCallModuleto indicate that it has stateful behavior.The TensorFlow side effect analysis has been updated to recursively analyze the TF host callback functions invoked by
tf.XlaCallModule.These changes ensure better compatibility and alignment with the
jax2tfnative serialization process, allowing for improved handling of side effects and seamless integration with TensorFlow.PiperOrigin-RevId: 533635753