Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fp32 compute result as the reference for tf32 test in ROCm as MIO… #60696

Merged
merged 1 commit into from Aug 2, 2023
Merged

Use fp32 compute result as the reference for tf32 test in ROCm as MIO… #60696

merged 1 commit into from Aug 2, 2023

Conversation

wenchenvincent
Copy link
Contributor

…pen does not support fp64.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label May 24, 2023
@wenchenvincent wenchenvincent force-pushed the rocm_use_fp32_reference_for_tf32 branch 2 times, most recently from befa7a1 to e5ccbdf Compare May 24, 2023 17:39
@wenchenvincent wenchenvincent marked this pull request as ready for review May 25, 2023 05:33
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation May 25, 2023
@gbaned gbaned requested a review from reedwm May 25, 2023 12:05
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label May 25, 2023
@wenchenvincent wenchenvincent mentioned this pull request Jun 2, 2023
Merged
@wenchenvincent wenchenvincent force-pushed the rocm_use_fp32_reference_for_tf32 branch 2 times, most recently from d1acdae to f7a4b2c Compare June 15, 2023 04:48
@gbaned
Copy link
Contributor

gbaned commented Jul 12, 2023

Hi @wenchenvincent Can you please resolve conflicts? Thank you!

@gbaned gbaned added stat:awaiting response Status - Awaiting response from author and removed awaiting review Pull request awaiting review labels Jul 12, 2023
@wenchenvincent wenchenvincent force-pushed the rocm_use_fp32_reference_for_tf32 branch from f7a4b2c to 4aad4ef Compare July 12, 2023 09:15
@wenchenvincent
Copy link
Contributor Author

Hi @wenchenvincent Can you please resolve conflicts? Thank you!

Conflicts resolved. Thanks!

@google-ml-butler google-ml-butler bot removed the stat:awaiting response Status - Awaiting response from author label Jul 12, 2023
@gbaned gbaned requested a review from BrianWieder July 12, 2023 09:31
@gbaned gbaned requested a review from cheshire July 20, 2023 09:29
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Jul 20, 2023
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 20, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 20, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 20, 2023
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Aug 1, 2023
@copybara-service copybara-service bot merged commit 1d66631 into tensorflow:master Aug 2, 2023
15 of 18 checks passed
PR Queue automation moved this from Approved by Reviewer to Merged Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherhut sherhut sherhut approved these changes

@reedwm reedwm Awaiting requested review from reedwm

@BrianWieder BrianWieder Awaiting requested review from BrianWieder

@cheshire cheshire Awaiting requested review from cheshire

Assignees

@gbaned gbaned

Labels
awaiting review Pull request awaiting review ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wenchenvincent @gbaned @sherhut @kokoro-team