Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneDNN] Adding a check to verify if gamma and beta are Const #63059

Merged

Conversation

othakkar
Copy link
Contributor

This PR resolves a segmentation fault for ResNet-DPED performance benchmark. The segmentation fault resulted with the following error: [libprotobuf FATAL external/com_google_protobuf/src/google/protobuf/map.h:1293] CHECK failed: it != end(): key not found: value. Adding a check to verify if gamma and beta are Const resolves the issue.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Feb 27, 2024
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Feb 27, 2024
@github-actions github-actions bot added the kokoro:force-run Tests on submitted change label Feb 27, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 27, 2024
@gbaned gbaned added the comp:grappler Grappler related issues label Feb 27, 2024
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Feb 27, 2024
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Feb 27, 2024
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Feb 27, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Feb 27, 2024
@copybara-service copybara-service bot merged commit badb95d into tensorflow:master Feb 27, 2024
10 of 12 checks passed
PR Queue automation moved this from Approved by Reviewer to Merged Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Pull request awaiting review comp:grappler Grappler related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants