Fix checkfail in UnicodeEncode Op #63398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Op UnicodeEncode segfaults when passed 2D tensor to `input_splits`. It has the below check in SetShapeFn which supposed to raise exception if rank !=1 AFAIk. This seems not working for reason unknown to me. https://github.com/tensorflow/tensorflow/blob/6f64ad5d767a034df45a5eaab8b36fd688cd1217/tensorflow/core/ops/string_ops.cc#L316-L317 Same with input_values argument also. Added an explicit check in Op.
sagunb
approved these changes
Mar 14, 2024
mihaimaruseac
approved these changes
Mar 14, 2024
gbaned
added
ready to pull
Closed
copybara-service bot
pushed a commit
that referenced
this pull request
Apr 2, 2024
Imported from GitHub PR #63398 The Op UnicodeEncode segfaults when passed 2D tensor to `input_splits`. It has the below check in `SetShapeFn` which supposed to raise exception if `rank !=1` AFAIk. This seems not working for reason unknown to me. https://github.com/tensorflow/tensorflow/blob/6f64ad5d767a034df45a5eaab8b36fd688cd1217/tensorflow/core/ops/string_ops.cc#L316-L317 Same with `input_values` argument also. Added an explicit check in Op. Ref issue #63379 Copybara import of the project: -- 176048a by Surya <116063290+SuryanarayanaY@users.noreply.github.com>: Fix checkfail in UnicodeEncode Op The Op UnicodeEncode segfaults when passed 2D tensor to `input_splits`. It has the below check in SetShapeFn which supposed to raise exception if rank !=1 AFAIk. This seems not working for reason unknown to me. https://github.com/tensorflow/tensorflow/blob/6f64ad5d767a034df45a5eaab8b36fd688cd1217/tensorflow/core/ops/string_ops.cc#L316-L317 Same with input_values argument also. Added an explicit check in Op. Merging this change closes #63398 FUTURE_COPYBARA_INTEGRATE_REVIEW=#63398 from tensorflow:Surya_UnicodeEncode 176048a PiperOrigin-RevId: 620612470
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Op UnicodeEncode segfaults when passed 2D tensor to
input_splits.It has the below check in
SetShapeFnwhich supposed to raise exception ifrank !=1AFAIk. This seems not working for reason unknown to me.tensorflow/tensorflow/core/ops/string_ops.cc
Lines 316 to 317 in 6f64ad5
Same with
input_valuesargument also.Added an explicit check in Op.
Ref issue #63379