[XLA:GPU] Explicit algorithm support for dot instructions #63429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_612391497
branch
from
417e0ad
to
1d44869
Compare
Now we can set PrecisionConfig::algorithm instead of PrecisionConfig::operand_precision. The old PrecisionConfig::operand_precision is also still supported. It would be a big change to remove it or even convert it to algorithm internally (because we support many type combinations and many tests would need to be updated). PrecisionConfig::algorithm is not yet added to StableHLO, so we can only use it if we feed an HLO to XLA directly. Future plans: - We would like to support it in StableHLO as well. - There are some plans to add similar algorithm support for convolution as well. - The code around matmul_utils.cc is a bit convoluted, so it may be cleaned up later. - We may write better tests for the algorithm support (actually checking if the correct code runs). PiperOrigin-RevId: 614996860
copybara-service
bot
force-pushed
the
test_612391497
branch
from
1d44869
to
7d6870d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:GPU] Explicit algorithm support for dot instructions
Now we can set PrecisionConfig::algorithm instead of PrecisionConfig::operand_precision.
The old PrecisionConfig::operand_precision is also still supported.
It would be a big change to remove it or even convert it to algorithm internally (because we support many type combinations and many tests would need to be updated).
PrecisionConfig::algorithm is not yet added to StableHLO, so we can only use it if we feed an HLO to XLA directly.
Future plans:
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#10011 from ROCm:ci_cusolver_fix_240227 d965fd3a817838c4b7440868afb6884ea011b078