When converting a graph to a module that came from MlirXlaOpKernel force the use of _output_shapes. #63434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_609858986
branch
4 times, most recently
from
bf5198c
to
9edce13
Compare
…rce the use of _output_shapes. When an Op is to be lowered by MlirXlaOpKernel all the output tensor shapes have been thrown away (except in the attribute) - this hasn't been a problem for most kernels because they generate the output shape based on inputs or other features; however, some Ops (e.g. _XlaHostComputeMlir') do not and are broken by the go/tuba bridge changes. This change forces the graph to module conversion to use the _output_shapes attribute, if present, to reintroduce the Op's shape. PiperOrigin-RevId: 614829760
copybara-service
bot
force-pushed
the
test_609858986
branch
from
9edce13
to
897493e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting a graph to a module that came from MlirXlaOpKernel force the use of _output_shapes.
When an Op is to be lowered by MlirXlaOpKernel all the output tensor shapes have been thrown away (except in the attribute) - this hasn't been a problem for most kernels because they generate the output shape based on inputs or other features; however, some Ops (e.g. _XlaHostComputeMlir') do not and are broken by the go/tuba bridge changes. This change forces the graph to module conversion to use the _output_shapes attribute, if present, to reintroduce the Op's shape.