Load OPENCL extensions correctly. #63499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_614647270
branch
3 times, most recently
from
4c4038d
to
2b56145
Compare
The existing implementation was incorrectly using loadOpenCLPointer to load extension functions. The correct way to load extensions according to the spec is the use clGetExtensionFunctionAddressForPlatform(). To ensure a less invasive change, add the function at the end of the default GPU device creation. PiperOrigin-RevId: 616060484
copybara-service
bot
force-pushed
the
test_614647270
branch
from
2b56145
to
b635e90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load OPENCL extensions correctly.
The existing implementation was incorrectly using loadOpenCLPointer to
load extension functions. The correct way to load extensions according to
the spec is the use clGetExtensionFunctionAddressForPlatform().
To ensure a less invasive change, add the function at the end of the
default GPU device creation.