Fix a typo in FollowReduceStrategy when creating following strategies for reduce ops. When computing communication and memory resharding costs for an operand of the reduce, we were using the shape of the reduce, instead of the shape of the operand. #63677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_615592099
branch
from
4c3806c
to
ba7c164
Compare
copybara-service
bot
changed the title
… for reduce ops. When computing communication and memory resharding costs for an operand of the reduce, we were using the shape of the reduce, instead of the shape of the operand. PiperOrigin-RevId: 615607643
copybara-service
bot
force-pushed
the
test_615592099
branch
from
ba7c164
to
39e138c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo in FollowReduceStrategy when creating following strategies for reduce ops. When computing communication and memory resharding costs for an operand of the reduce, we were using the shape of the reduce, instead of the shape of the operand.