[XLA:GPU] In Multi-output fusion, use BFS to check reachability #63707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Currently, MultiOutputFusion uses HloReachabilityMap, which builds reachability matrix on creation and element lookup on request. With multi-output fusion rebuilding the reachability after every step, that may take time. This change makes MultiOutputFusion to use a simple depth-first search reachability check, bounded by the post-order index. Namely, * To build the "map", the instructions are sorted in the post order, and indices are stored. * On the request, the DFS from the destination node is started, and only goes through nodes which have post-order index >= source node. With this approach, the MultiOutputFusion pass of one example HLO module goes from 34 minutes to 4 minutes. There are more advanced data structures that help even more (0.5 minutes), this will be done in the subsequent changes. PiperOrigin-RevId: 615730140
copybara-service
bot
force-pushed
the
test_615049679
branch
from
3f6e6a2
to
8cdcf82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:GPU] In Multi-output fusion, use BFS to check reachability
Currently, MultiOutputFusion uses HloReachabilityMap, which builds reachability matrix on creation and element lookup on request. With multi-output fusion rebuilding the reachability after every step, that may take time.
This change makes MultiOutputFusion to use a simple breadth-first search reachability check, bounded by the post-order index. Namely,
With this approach, the MultiOutputFusion pass of one example HLO module goes from 34 minutes to 4 minutes. There are more advanced data structures that help even more (0.5 minutes), this will be done in the subsequent changes.