Rewrite and simplify epilogue handling. #63793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_615719783
branch
from
16f7eaf
to
71282cc
Compare
The old approach ("isolated and injected") is confusing and doesn't work.
The new approach is to create a separate subgraph for the epilogue and
emit that as its own function. That way, only the epilogue needs to deal
with injected values.
This fixes most of the miscompiles in JAX. Transpose doesn't handle non-
trivial epilogues yet, but that should be an easy fix, similar to what's
done with reduce.
PiperOrigin-RevId: 616090173
copybara-service
bot
force-pushed
the
test_615719783
branch
from
71282cc
to
72bd6d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite and simplify epilogue handling.
The old approach ("isolated and injected") is confusing and doesn't work.
The new approach is to create a separate subgraph for the epilogue and
emit that as its own function. That way, only the epilogue needs to deal
with injected values.
This fixes most of the miscompiles in JAX. Transpose doesn't handle non-
trivial epilogues yet, but that should be an easy fix, similar to what's
done with reduce.