Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difficulty viewing "Lifetime of a PR" diagram in CONTRIBUTING.md if you have a dark background #64153

Closed
Aloqeely opened this issue Mar 21, 2024 · 0 comments · Fixed by #64155
Closed

Difficulty viewing "Lifetime of a PR" diagram in CONTRIBUTING.md if you have a dark background #64153

Aloqeely opened this issue Mar 21, 2024 · 0 comments · Fixed by #64155
Assignees
@tilakrayal

Comments

@Aloqeely
Copy link
Contributor

Aloqeely commented Mar 21, 2024 •
edited

In CONTRIBUTING.md, the diagram for lifetime of a PR becomes difficult to see when using github dark mode, this is because the text labels and lines within the diagram are black and lack a background color, making them blend in with the dark background

This is how it looks to me:
image

Suggested fix:
Add a white background color, for example:
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tilakrayal tilakrayal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update lifetime of a PR diagram image Aloqeely/tensorflow
2 participants
@Aloqeely @tilakrayal