[XLA:Python] Refactor jit argument parsing code. #64329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_618030729
branch
from
b22a550
to
6811d7b
Compare
* Put the logic to split static and dynamic arguments under ParseArguments, which returns a ArgumentSignature and a list of dynamic arguments. * Move the other argument parsing logic for jit and pmap into a separate CallSignature type. This simplifies the code, and prepares for adding another use case for the argument parsing code without the rest of the jit logic. Refactoring only, no functional changes intended. PiperOrigin-RevId: 619895559
copybara-service
bot
force-pushed
the
exported_pr_618030729
branch
from
6811d7b
to
1713d55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XLA:Python] Refactor jit argument parsing code.
This simplifies the code, and prepares for adding another use case for the argument parsing code without the rest of the jit logic.
Refactoring only, no functional changes intended.