Optimize XLA Compiler. #64357
Merged
Optimize XLA Compiler. #64357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
This results in 2% improvement on some representative large model compilation benchmarks. 1. `MayUseOperandValue(position.index, user)`, `(user->IsRoot() && root_positions.contains(user)` is computed once per <position, user> instead of once per <position, user, operand>. We don't need to pass `i` to `MayUseOperandValue`. We can instead bring the `CHECK` out at the call site. 2. Use `emplace_back` instead of `push_back` and `std::move`. Why: https://godbolt.org/z/sT54Ef88h PiperOrigin-RevId: 618429256
copybara-service
bot
force-pushed
the
exported_pr_617286277
branch
from
5cc594c
to
b20bcd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize XLA Compiler.
This results in 2% improvement on some representative large model compilation benchmarks.
MayUseOperandValue(position.index, user),(user->IsRoot() && root_positions.contains(user)is computed once per <position, user> instead of once per <position, user, operand>. We don't need to passitoMayUseOperandValue. We can instead bring theCHECKout at the call site.emplace_backinstead ofpush_backandstd::move. Why: https://godbolt.org/z/sT54Ef88h