Don't reset changed_ to false every time PerformSpaceToBatchOnConvolution is called. #64472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_619045068
branch
2 times, most recently
from
d04d4bf
to
43096f0
Compare
…tion is called. For example after PropagateOnUsers is called, new broadcast instructions are added so changed_ should be true. This makes it possible for the hlo module to be saved after this pass has rewrote or added new hlo instructions (module pertaining to the pass is only saved if there are changes). PiperOrigin-RevId: 619290345
copybara-service
bot
force-pushed
the
exported_pr_619045068
branch
from
43096f0
to
15acdd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't reset changed_ to false every time PerformSpaceToBatchOnConvolution is called.
For example after PropagateOnUsers is called, new broadcast instructions are added so changed_ should be true. This makes it possible for the hlo module to be saved after this pass has rewrote or added new hlo instructions (module pertaining to the pass is only saved if there are changes).