Use bytes proto field type for string values of xla::PjRtValueType to bytes
#64750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_620060088
branch
from
f803307
to
7df6ab9
Compare
…` to `bytes` `xla::PjRtValueType` is defined in C++, where its `std::string` value can contain any string (not necessarily UTF-8). Protobuf verison 3 requires a `string` field to contain UTF-8, so it is more suitable to use `bytes` to express this value. (Note that the string value of `xla::PjRtValueType` would be often consumed by Python, where nanobind would convert `std::string` into Python `str` with UTF-8 decoding. However, this is what some users of `xla::PjRtValueType` choose to do; this is not sufficient enough to constrain the string to be UTF-8 only in C++ APIs.) This is a preemptive change; there is no known problem of using a `string` field previously. PiperOrigin-RevId: 620315110
copybara-service
bot
force-pushed
the
exported_pr_620060088
branch
from
7df6ab9
to
f606d83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
bytesproto field type for string values ofxla::PjRtValueTypetobytesxla::PjRtValueTypeis defined in C++, where itsstd::stringvalue cancontain any string (not necessarily UTF-8). Protobuf verison 3 requires a
stringfield to contain UTF-8, so it is more suitable to usebytestoexpress this value.
(Note that the string value of
xla::PjRtValueTypewould be often consumed byPython, where nanobind would convert
std::stringinto Pythonstrwith UTF-8decoding. However, this is what some users of
xla::PjRtValueTypechoose todo; this is not sufficient enough to constrain the string to be UTF-8 only in
C++ APIs.)
This is a preemptive change; there is no known problem of using a
stringfield previously.