#shlo_ref Rework quantized tensor element types. #65134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
exported_pr_619572732
branch
from
6d17bed
to
52d7b02
Compare
This separates the implementation of per-tensor and per-axis quantization types. The goal is to allow value parametrized tests without having to use templating mechanisms to create the values. This will also make the user dispatching code much more concise. - Information duplication is reduced in the quantized type structures (only the variants). - The code is better decoupled. - Per-tensor does not need to get the per axis 0th element for scales and zero points. PiperOrigin-RevId: 622429656
copybara-service
bot
force-pushed
the
exported_pr_619572732
branch
from
52d7b02
to
522e500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#shlo_ref Rework quantized tensor element types.
This separates the implementation of per-tensor and per-axis quantization
types. The goal is to allow value parametrized tests without having to use
templating mechanisms to create the values. This will also make the user
dispatching code much more concise.