Remove unnecessary epilogue restrictions and corner cases. #66376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
- Allow injected values to be roots of epilogues - Allow n-ary values to be injected - Always generate an epilogue function if it's requested. - Simplify EmitEpilogue interface to hide indexes and calling convention details from the caller. This simplifies the logic in the reduction emitter somewhat. PiperOrigin-RevId: 627770230
copybara-service
bot
force-pushed
the
exported_pr_627744478
branch
from
72d10f4
to
b46d184
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary epilogue restrictions and corner cases.
details from the caller.
This simplifies the logic in the reduction emitter somewhat.