Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target '@llvm//:support' is not visible from target '@org_tensorflow//tensorflow/compiler/xla/client:compile_only_client'. #14445

Closed
carlthome opened this issue Nov 10, 2017 · 13 comments
Closed

Target '@llvm//:support' is not visible from target '@org_tensorflow//tensorflow/compiler/xla/client:compile_only_client'. #14445

carlthome opened this issue Nov 10, 2017 · 13 comments
Assignees
@hawkinsp
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower type:build/install Build and install issues

Comments

@carlthome
Copy link
Contributor

I was doing an XLA compilation that worked before TensorFlow 1.4 but now errors with

ERROR: /home/travis/build/carl/project/cache/bazel/external/org_tensorflow/tensorflow/compiler/xla/client/BUILD:107:1: Target '@llvm//:support' is not visible from target '@org_tensorflow//tensorflow/compiler/xla/client:compile_only_client'.

This is how I get tfcompile:

git clone https://github.com/tensorflow/tensorflow
cd tensorflow
git checkout v1.4.0 # Note: master also fails
PYTHON_BIN_PATH=$(which python) USE_DEFAULT_PYTHON_LIB_PATH=1 CC_OPT_FLAGS='-march=native'
  TF_ENABLE_XLA=0 TF_NEED_MPI=0 TF_NEED_JEMALLOC=1 TF_NEED_GCP=0 TF_NEED_HDFS=0
  TF_NEED_VERBS=0 TF_NEED_OPENCL=0 TF_NEED_CUDA=0 TF_NEED_GDR=0 TF_NEED_S3=0 TF_NEED_OPENCL_SYCL=0 ./configure
@angerson
Copy link
Contributor

Please provide details about what platform you are using (operating system, architecture). If you are unclear what to include see the issue template displayed in the Github new issue template.

We ask for this in the issue submission template, because it is really difficult to help without that information. Thanks!

@angerson angerson added type:build/install Build and install issues stat:awaiting response Status - Awaiting response from author labels Nov 10, 2017
@carlthome
Copy link
Contributor Author

Ubuntu Trusty on Travis with Bazel 0.7.0.

@ZihengJiang
Copy link
Contributor

I have the same problem on osx

@aselle aselle removed the stat:awaiting response Status - Awaiting response from author label Nov 13, 2017
@lissyx
Copy link
Contributor

lissyx commented Nov 14, 2017

Same on Debian Sid, Bazel v0.5.4.

@lissyx
Copy link
Contributor

lissyx commented Nov 14, 2017

I've been able to trigger my build after changing roughly a dozen of visibility to public in third_party/llvm/llvm.BUILD by trial/error ... Not sure if it's a legit solution, though.

@carlthome
Copy link
Contributor Author

I wonder how the Bazel in Jenkins differs from our configs considering the 1.4 tests passed. 😕

@lissyx
Copy link
Contributor

lissyx commented Nov 14, 2017 •
edited

@carlthome I took a chance and had a look at the tensorflow/tools/ci_build/ tooling. It turns out that it seems those run without sandbox, using --spawn_strategy=standalone --genrule_strategy=standalone.

edit Actually, I got tricked, it's really the use of tfcompile that triggers that, strategies have no impact whatsoever.

@cy89
Copy link

cy89 commented Nov 15, 2017

@jart this seems potentially like a build issue rather than an XLA issue. Would you PTAL?

@cy89 cy89 added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Nov 15, 2017
@hawkinsp hawkinsp self-assigned this Nov 15, 2017
@hawkinsp
Copy link
Contributor

I've pushed a fix for this to our staging tree, it will make its way to Github shortly.

If you wish to workaround this locally in your tree, just change this line:
https://github.com/tensorflow/tensorflow/blob/master/third_party/llvm/llvm.BUILD#L21
from
package(default_visibility = ["@%ws%//tensorflow/compiler/xla:internal"])
to
package(default_visibility = ["//visibility:public"])

@jart
Copy link
Contributor

jart commented Nov 15, 2017

Sounds like @hawkinsp has got this one under control. That main repo reference issue has always been somewhat problematic.

@lissyx
Copy link
Contributor

lissyx commented Nov 15, 2017

Thanks @hawkinsp, it's indeed a generalization of the workaround I was working with, as documented above :)

@lissyx lissyx mentioned this issue Nov 15, 2017
Closed
@jhseu jhseu closed this as completed in 94b2754 Nov 16, 2017
lissyx pushed a commit to lissyx/tensorflow that referenced this issue Nov 17, 2017
@hawkinsp
Replace uses of @%ws% with @org_tensorflow in LLVM BUILD file. @%ws% …
ce22729 
…existed to work around a bug in older Bazel versions. The minimum Bazel version no longer has this issue so we can just write @org_tensorflow.

Fixes tensorflow#14445.

PiperOrigin-RevId: 175756784
@carlthome
Copy link
Contributor Author

Works again for me now. Thanks!

@lissyx
Copy link
Contributor

lissyx commented Nov 17, 2017

I can confirm it also works for us. Thanks!

k-w-w pushed a commit that referenced this issue Nov 17, 2017
@hawkinsp @k-w-w
Replace uses of @%ws% with @org_tensorflow in LLVM BUILD file. @%ws% …
51ad40f 
…existed to work around a bug in older Bazel versions. The minimum Bazel version no longer has this issue so we can just write @org_tensorflow.

Fixes #14445.

PiperOrigin-RevId: 175756784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hawkinsp hawkinsp

Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower type:build/install Build and install issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@jart @aselle @hawkinsp @carlthome @lissyx @ZihengJiang @cy89 @angerson