Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tensorflow broken by new Bazel versions #15137

Closed
laurentlb opened this issue Dec 5, 2017 · 5 comments
Closed

Tensorflow broken by new Bazel versions #15137

laurentlb opened this issue Dec 5, 2017 · 5 comments
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower

Comments

@laurentlb
Copy link
Contributor

Simplest way to reproduce the issue, run:
$ bazel build --config=opt --incompatible_load_argument_is_label --nobuild //tensorflow/tools/pip_package:build_pip_package

Suggested fix to tensorflow/third_party/sycl/sycl/BUILD.tpl:

-load("platform", "sycl_library_path")
+load(":platform.bzl", "sycl_library_path")

-load("platform", "readlink_command")
+load(":platform.bzl", "readlink_command")

This should address the immediate need.
There are other issues to fix (although not as pressing). You can see them by building using --all_incompatible_changes.

Let me know if you need any help.
Thanks!
@reedwm
Copy link
Member

reedwm commented Dec 5, 2017

/CC @gunan, can you resolve this?

@reedwm reedwm added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Dec 5, 2017
@gunan
Copy link
Contributor

gunan commented Dec 5, 2017

Thanks for the report @laurentlb Could you file a bug internally for us to quickly triage this?

@angerson
Copy link
Contributor

angerson commented Dec 5, 2017 •
edited

I've prepared a change that will fix this -- first internally, then externally, once the repositories are synced.

@laurentlb laurentlb mentioned this issue Dec 6, 2017
Closed
@angerson
Copy link
Contributor

angerson commented Dec 6, 2017

The fix has been applied to our internal branch. The next repository sync should bring the fix over to Github.

@laurentlb
Copy link
Contributor Author

Thanks!

caisq pushed a commit to caisq/tensorflow that referenced this issue Dec 7, 2017
@angerson @tensorflower-gardener
Fix some build incompatibilities with new versions of Bazel
d9a71ad 
See tensorflow#15137.

PiperOrigin-RevId: 178037461
@gunan gunan closed this as completed Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@laurentlb @reedwm @gunan @angerson