Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting rid of all_opensource_files #15758

Closed
5 tasks done
Androbin opened this issue Dec 31, 2017 · 8 comments
Closed
5 tasks done

Getting rid of all_opensource_files #15758

Androbin opened this issue Dec 31, 2017 · 8 comments
Assignees
@Androbin

Comments

@Androbin
Copy link
Contributor

Androbin commented Dec 31, 2017 •
edited

This ticket is for tracking the progress of removing the all_opensource_files bazel target.
See the discussion in #15368.
@Androbin
Copy link
Contributor Author

@yifeif Which parts of the makefile build depend on all_opensource_files ?

@Androbin
Copy link
Contributor Author

@gunan What do we need the wrapper around makefile builds for?

@gunan
Copy link
Contributor

gunan commented Jan 23, 2018

New build infra requires bazel to execute builds. We need to make changes in the infra config to get rid of all opensource files.

@yifeif will need to take a look at that.

@Androbin
Copy link
Contributor Author

Is the //tensorflow/contrib/makefile:build_all_linux target even used anywhere?

grep -r "build_all_linux" yields just this:

./tensorflow/contrib/makefile/README.md:You should then be able to run the `build_all_linux.sh` script to compile:
./tensorflow/contrib/makefile/README.md:tensorflow/contrib/makefile/build_all_linux.sh
./tensorflow/contrib/makefile/BUILD:    name = "build_all_linux",
./tensorflow/contrib/makefile/BUILD:    srcs = ["build_all_linux.sh"],
./tensorflow/contrib/makefile/build_with_docker.sh:COMMAND="tensorflow/contrib/makefile/build_all_linux.sh"

Or is the target used somewhere outside this repo?

@Androbin Androbin mentioned this issue Jan 27, 2018
Closed
@gunan
Copy link
Contributor

gunan commented Jan 29, 2018

Yes, the infra config we have is outside the repository.

@Androbin Androbin mentioned this issue Feb 3, 2018
Closed
case540 pushed a commit to case540/tensorflow that referenced this issue Feb 6, 2018
@yifeif @tensorflower-gardener
Remove makefile build dependency on all_opensource_files, as part of …
aea9333 
…the effort to remove all_opensource_files tensorflow#15758.

PiperOrigin-RevId: 184601439
@yifeif
Copy link
Contributor

yifeif commented Feb 6, 2018

FYI we have removed all our dependencies on all_opensource_files.

@tensorflowbutler
Copy link
Member

Nagging Assignee: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

@Androbin Androbin mentioned this issue Mar 2, 2018
Closed
@tensorflowbutler
Copy link
Member

Nagging Assignee @Androbin: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Androbin Androbin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yifeif @gunan @Androbin @tensorflowbutler