Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Recommendation] Expose tensorflow/core/kernels/dataset.h in wheel file #16682

Closed
galv opened this issue Feb 2, 2018 · 0 comments
Closed

[Recommendation] Expose tensorflow/core/kernels/dataset.h in wheel file #16682

galv opened this issue Feb 2, 2018 · 0 comments
Assignees
Labels
type:build/install Build and install issues

Comments

@galv
Copy link

galv commented Feb 2, 2018

Hi,

Right now, to build a new dataset op, you need to access to the header file tensorflow/core/kernels/dataset.h, but the tensorflow wheel does not expose this header.

Use case: I built new Dataset Ops to read Kaldi's "Table" I/O format to enable others to be able to move from Kaldi-based automatic speech recognition recipes to tensorflow-based ones without having to do a bunch of extra data-munging. Right now, I require users to build tensorflow from source code and point my build to the tensorflow source code path, so I can guarantee that I have access to a header file compatible with their binary. I'd prefer to be able to build my package by depending only on pip-installed tensorflow to make things easier on users.

I manually verified that adding

"//tensorflow/core/kernels:dataset",

to the deps of

transitive_hdrs(
    name = "included_headers",
    deps = [
        "//tensorflow/core:core_cpu",
        "//tensorflow/core:framework",
        "//tensorflow/core:lib",
        "//tensorflow/core:protos_all_cc",  
        "//tensorflow/core:stream_executor",
        "//third_party/eigen3",
    ],
)

in tensorflow/tools/pip_package/BUILD will include the right header file.

This is a pretty small change. Is there a particular reason why tensorflow does not already expose the header file? Is this an oversight or because you aren't ready to expose this interface publically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:build/install Build and install issues
Projects
None yet
Development

No branches or pull requests

3 participants