Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

df982b8de - Split gpu_id.h and GpuIdManager out from build target breaks build for verbs and GDR #16976

Closed
eladweiss opened this issue Feb 13, 2018 · 4 comments
Closed

df982b8de - Split gpu_id.h and GpuIdManager out from build target breaks build for verbs and GDR #16976

eladweiss opened this issue Feb 13, 2018 · 4 comments
Assignees
@aaroey

Comments

@eladweiss
Copy link
Contributor

System information

  • Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No.
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
  • TensorFlow installed from (source or binary): Source
  • TensorFlow version (use command below): TF not compiling. (master)
  • Python version: 2.7
  • Bazel version (if compiling from source): 0.5.4
  • GCC/Compiler version (if compiling from source): 5.4
  • CUDA/cuDNN version: 9.1
  • GPU model and memory: Any
  • Exact command to reproduce:
  1. ./configure ... with GDR (and/or verbs)
  2. bazel build -c opt --config=cuda //tensorflow/tools/pip_package:build_pip_package

Describe the problem

Commit df982b8 breaks the build for GDR and verbs.

ERROR: /home/eladw/google/tensorflow/tensorflow/contrib/gdr/BUILD:52:1: undeclared inclusion(s) in rule '//tensorflow/contrib/gdr:gdr_memory_manager':
this rule is missing dependency declarations for the following files included by 'tensorflow/contrib/gdr/gdr_memory_manager.cc':
'/home/eladw/google/tensorflow/tensorflow/core/common_runtime/gpu/gpu_id.h'.
@cy89
Copy link

cy89 commented Feb 14, 2018

@aaroey is fixing this within your wheelhouse?

@cy89 cy89 assigned cy89 and aaroey and unassigned cy89 Feb 14, 2018
@byronyi
Copy link
Contributor

byronyi commented Feb 14, 2018

Thanks @eladweiss :)

@aaroey
Copy link
Member

aaroey commented Feb 14, 2018

Thanks for pointing out. Working on the fix.

@aaroey
Copy link
Member

aaroey commented Feb 17, 2018

Fixed by febed14.

@aaroey aaroey closed this as completed Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaroey aaroey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@byronyi @cy89 @eladweiss @aaroey