Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keras guide webpage: tf.keras.version links to a dead webpage. #20913

Closed
pathak-ashutosh opened this issue Jul 18, 2018 · 12 comments
Closed

Keras guide webpage: tf.keras.version links to a dead webpage. #20913

pathak-ashutosh opened this issue Jul 18, 2018 · 12 comments
Assignees

Comments

@pathak-ashutosh
Copy link

pathak-ashutosh commented Jul 18, 2018

System Information

Have I written custom code: No
OS Platform and Distribution: Windows 10 Pro
TensorFlow installed from: source
TensorFlow version: N/A
Bazel version: N/A
CUDA/cuDNN version: N/A
GPU model and memory: Nvidia GeForce GTX 950m 4GB
Exact command to reproduce: N/A

Describe the problem

  • On this TensorFlow guide website, I found that it mentions using tf.keras.version to check the keras version. However, it should be tf.keras.__version__ instead of tf.keras.version.

  • Also, it links to a webpage which throws 404 error.

tf keras issue

@tensorflowbutler tensorflowbutler added the stat:awaiting response Status - Awaiting response from author label Jul 18, 2018
@tensorflowbutler
Copy link
Member

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Have I written custom code
OS Platform and Distribution
TensorFlow installed from
TensorFlow version
Bazel version
CUDA/cuDNN version
GPU model and memory
Exact command to reproduce

@pathak-ashutosh
Copy link
Author

pathak-ashutosh commented Jul 18, 2018

Fixed it.

@drpngx drpngx closed this as completed Jul 18, 2018
@drpngx
Copy link
Contributor

drpngx commented Jul 18, 2018

Thanks!

@pathak-ashutosh
Copy link
Author

pathak-ashutosh commented Jul 18, 2018

I'm sorry for the confusion, but I said 'fixed it' to tell that I fixed the thing that the bot was talking about regarding the template. Not because the issue was fixed @drpngx

@drpngx drpngx reopened this Jul 18, 2018
@drpngx drpngx added stat:contribution welcome Status - Contributions welcome and removed stat:awaiting response Status - Awaiting response from author labels Jul 18, 2018
@drpngx
Copy link
Contributor

drpngx commented Jul 18, 2018

I think that makes sense. Please send a PR.

@pathak-ashutosh
Copy link
Author

I can't find the website code in tensorflow/tensorflow repository. Can you point me to it?

@drpngx
Copy link
Contributor

drpngx commented Jul 19, 2018

It's probably here.

@pathak-ashutosh
Copy link
Author

I checked that file already. There's no issue in the file, it's all correct. But the webpage is different (as shown in the screenshot above) than this Keras.md file that you shared. The webpage documentation has the issue.

Just like there's a tfjs-website repository for tensorflow.js website, I want to know how I can fix the issue on tensorflow.org website.

I hope this makes it clear.

@drpngx
Copy link
Contributor

drpngx commented Jul 19, 2018

The file seems to say tf.keras.__version__ at line 35, right?

@drpngx
Copy link
Contributor

drpngx commented Jul 19, 2018

For the website, probably @MarkDaoust can fix it directly.

@MarkDaoust MarkDaoust assigned MarkDaoust and unassigned drpngx Jul 19, 2018
@MarkDaoust
Copy link
Member

Yes. Thanks.

We're working on breaking the website out of the main repo so that we're not tied to release branches, as we currently are.

That will let us fix things like this more easily.

The 404 ... probably needs a fix to the api-reference generator. simple constants don't have api pages. That will take some work.

@MarkDaoust MarkDaoust removed the stat:contribution welcome Status - Contributions welcome label Aug 3, 2018
@drpngx drpngx assigned MarkDaoust and unassigned drpngx Aug 4, 2018
@tensorflowbutler
Copy link
Member

Nagging Assignee @MarkDaoust: It has been 29 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants