-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ppc64le: //tensorflow/contrib/tensor_forest:scatter_add_ndim_op_test #21833
Comments
I had read online that ScatterAddNdim had no GPU support, I looked at https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/tensor_forest/BUILD#L460-L465, and see the testcase has a tag 'no-pip-gpu'. So I believe this test shouldn't run in a GPU unit test, but the unit test only exclude the test matching the tag no-gpu. @gunan - Can I get your opinion on how to fix it. I see three ways:
CC @jayfurmanek, He would prefer to test as much as possible in the GPU test. |
I think 3. there is the most interesting one for me. We do ship most of contrib (with limited support) in PowerAI so maximum test coverage is ideal. |
Sorry for the late reply. |
As scatter_add_ndim doesn't have implementation for GPU, the test needs to be excluded from GPU test to prevent it from failing. Currently fails on both x86_64 and ppc64le. Fixes tensorflow#21833
Please assign this issue to me
System information
azel test --config=cuda --test_tag_filters=-no_oss,-oss_serial,-no_gpu,-benchmark-test --test_timeout 300,450,1200,3600 --local_test_jobs=4 --test_output=errors --build_tests_ //tensorflow/tools/ci_build/gpu_build:parallel_gpu_execute //tensorflow/contrib/tensor_forest:scatter_add_ndim_op_test
Describe the problem
5 of 6 testcases fail with error similar to:
Source code / logs
The text was updated successfully, but these errors were encountered: