Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think 'class EmbeddingWrapper' has problem #2852

Closed
yanghoonkim opened this issue Jun 14, 2016 · 2 comments
Closed

I think 'class EmbeddingWrapper' has problem #2852

yanghoonkim opened this issue Jun 14, 2016 · 2 comments
Assignees

Comments

@yanghoonkim
Copy link

yanghoonkim commented Jun 14, 2016

I found that there are some differences between r0.7 and r0.9 which is that : class EmbeddingWrapper in rnn_cell.py in r0.9 doens't has some @Property values, just like def input_size , def output_size . and when i run rnn.rnn with embeded cell, it causes an NotImplementedError which is from RNNCell 's function

def __call__(self, inputs, state, scope=None):
    """Run this RNN cell on inputs, starting from the given state.

    Args:
      inputs: `2-D` tensor with shape `[batch_size x input_size]`.
      state: if `self.state_size` is an integer, this should be a `2-D Tensor`
        with shape `[batch_size x self.state_size]`.  Otherwise, if
        `self.state_size` is a tuple of integers, this should be a tuple
        with shapes `[batch_size x s] for s in self.state_size`.
      scope: VariableScope for the created subgraph; defaults to class name.

    Returns:
      A pair containing:
      - Output: A `2-D` tensor with shape `[batch_size x self.output_size]`.
      - New state: Either a single `2-D` tensor, or a tuple of tensors matching
        the arity and shapes of `state`.
    """
    raise NotImplementedError("Abstract method")

Did i do something wrong?

@ebrevdo
Copy link
Contributor

ebrevdo commented Jun 15, 2016

Lukasz, ptal?

benoitsteiner pushed a commit to benoitsteiner/tensorflow that referenced this issue Jun 16, 2016
…y do not

create variables. Also add missing output_size in EmbeddingWrapper (tensorflow#2852).
Change: 125022470
@lukaszkaiser
Copy link
Contributor

I made a code change correcting it (adding output_state to EmbeddingWrapper), so that should be working now on master. Closing, please re-open if it's still not working.

martinwicke pushed a commit to martinwicke/tensorflow that referenced this issue Jun 19, 2016
…y do not

create variables. Also add missing output_size in EmbeddingWrapper (tensorflow#2852).
Change: 125022470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants