Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated target in TFLite Makefile ? #42504

Closed
kalaluthien opened this issue Aug 20, 2020 · 2 comments
Closed

Duplicated target in TFLite Makefile ? #42504

kalaluthien opened this issue Aug 20, 2020 · 2 comments
Assignees
@terryheo
Labels
comp:lite TF Lite related issues type:bug Bug
Projects
TensorFlow 2.4.0

Comments

@kalaluthien
Copy link

Describe the current behavior
It seems that there is a duplicated target in lite/tools/make/Makeflie

https://github.com/tensorflow/tensorflow/blob/master/tensorflow/lite/tools/make/Makefile#L318-L320

# For normal manually-created TensorFlow Lite C++ source files.
$(OBJDIR)%.o: %.cpp
	@mkdir -p $(dir $@)
	$(CXX) $(CXXFLAGS) $(INCLUDES) -c $< -o $@

$(OBJDIR)%.o: %.cc
	@mkdir -p $(dir $@)
	$(CXX) $(CXXFLAGS) $(INCLUDES) -c $< -o $@

# For normal manually-created TensorFlow Lite C source files.
$(OBJDIR)%.o: %.c
	@mkdir -p $(dir $@)
	$(CC) $(CFLAGS) $(INCLUDES) -c $< -o $@
$(OBJDIR)%.o: %.cpp  # Is this proper target?
	@mkdir -p $(dir $@)
	$(CXX) $(CXXFLAGS) $(INCLUDES) -c $< -o $@

Describe the expected behavior

# For normal manually-created TensorFlow Lite C++ source files.
$(OBJDIR)%.o: %.cpp
	@mkdir -p $(dir $@)
	$(CXX) $(CXXFLAGS) $(INCLUDES) -c $< -o $@

$(OBJDIR)%.o: %.cc
	@mkdir -p $(dir $@)
	$(CXX) $(CXXFLAGS) $(INCLUDES) -c $< -o $@

# For normal manually-created TensorFlow Lite C source files.
$(OBJDIR)%.o: %.c
	@mkdir -p $(dir $@)
	$(CC) $(CFLAGS) $(INCLUDES) -c $< -o $@
#$(OBJDIR)%.o: %.cpp
#	@mkdir -p $(dir $@)
#	$(CXX) $(CXXFLAGS) $(INCLUDES) -c $< -o $@
@kalaluthien kalaluthien added the type:bug Bug label Aug 20, 2020
@kalaluthien kalaluthien changed the title Redundant target in TFLite Makefile Duplicated target in TFLite Makefile ? Aug 20, 2020
@amahendrakar amahendrakar added the comp:lite TF Lite related issues label Aug 20, 2020
@amahendrakar amahendrakar assigned ymodak and unassigned amahendrakar Aug 20, 2020
@ymodak ymodak assigned terryheo and unassigned ymodak Aug 24, 2020
@terryheo
Copy link
Member

Thanks for reporting this. I'll prepare a PR.

@google-ml-butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

@geetachavan1 geetachavan1 added this to To do in TensorFlow 2.4.0 via automation Sep 29, 2020
@geetachavan1 geetachavan1 moved this from To do to Done in TensorFlow 2.4.0 Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terryheo terryheo

Labels
comp:lite TF Lite related issues type:bug Bug
Projects
TensorFlow 2.4.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@terryheo @kalaluthien @ymodak @amahendrakar