Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models/rnn/ptb not included in pip package #69

Closed
teamdandelion opened this issue Nov 10, 2015 · 6 comments
Closed

models/rnn/ptb not included in pip package #69

teamdandelion opened this issue Nov 10, 2015 · 6 comments

Comments

@teamdandelion
Copy link
Contributor

No description provided.

@teamdandelion
Copy link
Contributor Author

Apparently this is working as intended - in general models should be sourced from the repo, not the pip package.

@vrv
Copy link

vrv commented Nov 10, 2015

So are our instructions incorrect somewhere? We should update them if that's the case.

@ebrevdo
Copy link
Contributor

ebrevdo commented Nov 10, 2015

People get confused because build_pip_package imports models/rnn/{rnn,rnn_cell,seq2seq}. If/when we move these into python.ops.nn (e.g. something like nn.rnn, nn.rnn_cell, nn.seq2seq); that should fix some of the confusion.

@vrv
Copy link

vrv commented Nov 10, 2015

Agreed. Until we are ready to support those interfaces indefinitely, is there something we should do to avoid that confusion? Should we remove models/rnn from the pip package?

@ebrevdo
Copy link
Contributor

ebrevdo commented Nov 10, 2015

No, they are the proper rnn/lstm implementation and should be made
available with the rest of the ops.
On Nov 10, 2015 1:08 PM, "Vijay Vasudevan" notifications@github.com wrote:

Agreed. Until we are ready to support those interfaces indefinitely, is
there something we should do to avoid that confusion? Should we remove
models/rnn from the pip package?


Reply to this email directly or view it on GitHub
#69 (comment)
.

@evanthebouncy
Copy link

is this the reason why the rnn/lstm is not in the documentation under nn (in the api doc)?

Just for the time being, what's the best resources to learn how to use them? I've just been reading the rnn and seq-to-seq tutorial, as there is no documentations for these modules.

lissyx added a commit to lissyx/tensorflow that referenced this issue Apr 17, 2018
tensorflow-copybara pushed a commit that referenced this issue Aug 9, 2019
This adds support for fcmp to the LLVM dialect and adds any necessary lowerings, as well as support for EDSCs.

Closes #69

COPYBARA_INTEGRATE_REVIEW=tensorflow/mlir#69 from nmostafa:nmostafa/fcmp 9115ad4901d4eeda130066db0a6806d6159afe09
PiperOrigin-RevId: 262475255
copybara-service bot pushed a commit that referenced this issue May 17, 2022
PiperOrigin-RevId: 449110428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants