Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for non-scalar string tensors in java #8531

Closed
ophiry opened this issue Mar 19, 2017 · 11 comments
Closed

Add support for non-scalar string tensors in java #8531

ophiry opened this issue Mar 19, 2017 · 11 comments
Assignees
@asimshankar
Labels
type:feature Feature requests

Comments

@ophiry
Copy link

ophiry commented Mar 19, 2017

Currently, string tensors are not supported in java:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/java/src/main/java/org/tensorflow/Tensor.java#L90

Implementing this would be very helpful in scenarios of training a model in one language, and serving from a different one, as it allows moving some of the logic to the tensor flow model.
@concretevitamin
Copy link
Contributor

/cc @asimshankar

@concretevitamin concretevitamin added the type:feature Feature requests label Mar 20, 2017
@asimshankar asimshankar added the stat:contribution welcome Status - Contributions welcome label Mar 20, 2017
@asimshankar
Copy link
Contributor

I'm under the impression that someone is working on a contribution for this. I'll check in with them to see if they expect to send a PR anytime soon.

@erranli
Copy link

erranli commented Apr 7, 2017

I completed the implementation of the feature and will contribute it back soon.

@jan-apptornado
Copy link

Thanks a lot for making this possible. Any idea when "soon" is?

@asimshankar asimshankar mentioned this issue May 19, 2017
Closed
@Moriadry-zz Moriadry-zz mentioned this issue Jun 13, 2017
Closed
@asimshankar asimshankar changed the title Add support for string tensors in java Add support for multi-dimensional string tensors in java Aug 18, 2017
@asimshankar asimshankar changed the title Add support for multi-dimensional string tensors in java Add support for non-scalar string tensors in java Aug 18, 2017
@quaeler
Copy link
Contributor

quaeler commented Aug 23, 2017

@erranli could you push your fix, or cut this issue loose?

@asimshankar
Copy link
Contributor

@quaeler : I had an earlier attempt at this than I can resurrect. I'll do that and hope to have something in the next few days.

@asimshankar asimshankar self-assigned this Aug 23, 2017
@asimshankar asimshankar removed the stat:contribution welcome Status - Contributions welcome label Aug 23, 2017
@quaeler
Copy link
Contributor

quaeler commented Aug 23, 2017

@asimshankar ok sounds good; if you want to pass the baton, i'm happy to do the resurrection as well.

@quaeler
Copy link
Contributor

quaeler commented Aug 30, 2017

Thanks @ebrevdo - any reason not make this into a PR for tensorflow master?

@ebrevdo
Copy link
Contributor

ebrevdo commented Aug 31, 2017

Please ignore my commit; this was written by @asimshankar and will show up on master soon.

@caisq caisq closed this as completed in db1e43e Aug 31, 2017
@quaeler quaeler mentioned this issue Sep 2, 2017
Merged
kobejean pushed a commit to kobejean/tensorflow that referenced this issue Sep 3, 2017
@asimshankar @kobejean
Java: Support multi-dimensional STRING tensors.
43f8af1 
Fixes tensorflow#8531

PiperOrigin-RevId: 166749470
@myanything
Copy link

@caisq thank you for making the change. Curious when will the change be published to maven central?

@asimshankar
Copy link
Contributor

This is part of 1.4, so is available on Maven Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asimshankar asimshankar

Labels
type:feature Feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@asimshankar @concretevitamin @ebrevdo @myanything @ophiry @jan-apptornado @erranli @quaeler