Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF-TRT C++ conversion example #271

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Sep 22, 2021

C++ conversion example to illustrate conversion using dynamic shape mode.

This PR depends on tensorflow/tensorflow#52012

@tfeher tfeher marked this pull request as ready for review September 26, 2021 23:47
@christopherbate
Copy link

I think we're trying to follow convention of labeling PR titles with the tag [TF:TRT]

Copy link

@christopherbate christopherbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly build system / scripts and instructions need to be updated for final version, other things are minor.

tftrt/examples/cpp/image-classification/README.md Outdated Show resolved Hide resolved
tftrt/examples/cpp/image-classification/README.md Outdated Show resolved Hide resolved
tftrt/examples/cpp/image-classification/README.md Outdated Show resolved Hide resolved
cd tensorrt/tftrt/examples/cpp/image-classification
mkdir build
cd build
cmake ..

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to include -D... when CMakeLists is finalized

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of the these, do we want to add hints for TF_SOURCE_DIR / TF_INSTALL_DIR?

tftrt/examples/cpp/image-classification/main.cc Outdated Show resolved Hide resolved
tftrt/examples/cpp/image-classification/main.cc Outdated Show resolved Hide resolved
tftrt/examples/cpp/image-classification/main.cc Outdated Show resolved Hide resolved
tftrt/examples/cpp/image-classification/main.cc Outdated Show resolved Hide resolved
Copy link
Contributor Author

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @christopherbate for the review, I have addressed the issues.

tftrt/examples/cpp/image-classification/README.md Outdated Show resolved Hide resolved
tftrt/examples/cpp/image-classification/README.md Outdated Show resolved Hide resolved
tftrt/examples/cpp/image-classification/README.md Outdated Show resolved Hide resolved
tftrt/examples/cpp/image-classification/main.cc Outdated Show resolved Hide resolved
tftrt/examples/cpp/image-classification/mnist.cc Outdated Show resolved Hide resolved
tftrt/examples/cpp/image-classification/mnist.h Outdated Show resolved Hide resolved
tftrt/examples/cpp/image-classification/mnist.h Outdated Show resolved Hide resolved
tftrt/examples/cpp/image-classification/main.cc Outdated Show resolved Hide resolved
@tfeher
Copy link
Contributor Author

tfeher commented Oct 20, 2021

To compile the example, one needs PR tensorflow/tensorflow#52595

@DEKHTIARJonathan
Copy link
Collaborator

@meena-at-work: for review

Copy link
Collaborator

@meena-at-work meena-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants