This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
Compile data/es6/compiled_api.js to es5 syntax while using es6 modules #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsmilkov
changed the title
dist-es6/
nsthorat
reviewed
Jul 6, 2018
complete! 1 of 1 LGTMs obtained
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve interoperability with React and other libraries, (see discussion and http://bit.ly/2tRViJ9), we should compile
es6/compiled_api.jsto es5 while still using es6 modules. We do this using the typescript compiler which allows js files as inputs.This removes the need for the manual
sedcommand to manually replace=>withfunction()This change is