Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

add @doc to the public class and api #176

Merged
merged 6 commits into from
Jul 24, 2018
Merged

add @doc to the public class and api #176

merged 6 commits into from
Jul 24, 2018

Conversation

pyu10055
Copy link
Collaborator

@pyu10055 pyu10055 commented Jul 19, 2018

This allows converter API to show up in the tfjs API website.

ref tensorflow/tfjs#520


This change is Reviewable

@pyu10055 pyu10055 requested a review from nsthorat July 19, 2018 17:32
Copy link

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055 and @nsthorat)


src/executor/frozen_model.ts, line 270 at r1 (raw file):

 * and custom headers.
 */
/** @doc {heading: 'Models', subheading: 'Loading'} */

want to add a snippet here as well? you could load mobilenet, or another model that we've hosted

Copy link
Collaborator Author

@pyu10055 pyu10055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055)


src/executor/frozen_model.ts, line 270 at r1 (raw file):

Previously, nsthorat (Nikhil Thorat) wrote…

want to add a snippet here as well? you could load mobilenet, or another model that we've hosted

added, thanks.

Copy link

@nsthorat nsthorat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: 0 of 1 approvals obtained (waiting on @nsthorat and @pyu10055)


src/executor/frozen_model.ts, line 31 at r2 (raw file):

 * SavedModel GraphDef and allows inference exeuction.
 */

remove this empty line (google3 doesn't like it)


src/executor/frozen_model.ts, line 263 at r2 (raw file):

/**
 * Load the frozen model through url.

"Load the frozen model from a URL."


src/executor/frozen_model.ts, line 265 at r2 (raw file):

 * Load the frozen model through url.
 *
 * Example loading the MobileNetV2 model and run inference for an all zero

"Example of loading MobileNet and making a prediction with a zeros input."

@nsthorat
Copy link

Nice!

@pyu10055 pyu10055 merged commit 0929732 into master Jul 24, 2018
@pyu10055 pyu10055 deleted the docs branch July 24, 2018 17:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants