Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

added support for TopK op #182

Merged
merged 8 commits into from
Jul 24, 2018
Merged

added support for TopK op #182

merged 8 commits into from
Jul 24, 2018

Conversation

pyu10055
Copy link
Collaborator

@pyu10055 pyu10055 commented Jul 23, 2018

This change is Reviewable

@pyu10055 pyu10055 requested a review from dsmilkov July 23, 2018 23:18
Copy link
Contributor

@dsmilkov dsmilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055 and @dsmilkov)


src/executor/graph_executor_test.ts, line 74 at r1 (raw file):

    constNode.children.push(outputNode);
    executor = new GraphExecutor(graph);
    constTensor = tfc.scalar(2);

I think this PR has changes from another PR that is not yet merged. Might want to resolve that.

@pyu10055 pyu10055 merged commit d7ab001 into master Jul 24, 2018
@dsmilkov dsmilkov deleted the topK branch July 29, 2018 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants