This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
Add support for shapeN operation #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhwang
force-pushed
the
add_op_shapen
branch
from
be1f329
to
92bd4de
Compare
|
when trying to use the speech recognition in transformer model, several operations are missing and One question: this PR handles |
pyu10055
suggested changes
Sep 12, 2018
| node.op = 'shapeN'; | ||
| expect( | ||
| (executeOp(node, | ||
| { input1, input2: input3 }, context) as tfc.Tensor[]) |
There was a problem hiding this comment.
the feed here is bit confusing, you can change to
node.inputNames = ['input1', 'input3'];
executeOp(node, { input1, input3 }, context)
There was a problem hiding this comment.
you're right. fixed!
Support shapeN operation and also add a test case for it. Signed-off-by: Yihong Wang <yh.wang@ibm.com>
yhwang
force-pushed
the
add_op_shapen
branch
from
92bd4de
to
c1a21ac
Compare
pyu10055
approved these changes
Sep 13, 2018
|
@pyu10055 thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support shapeN operation and also add
a test case for it.
Signed-off-by: Yihong Wang yh.wang@ibm.com
This change is