This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
io_utils: use Buffer methods instead of Blob/atob/btoa on Node.js #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure if this is the best path forward to implement those, but I wasn't able to find an existing mechanism for overriding those methods from |
ChALkeR
changed the title
This should fix `arrayBufferToBase64String` and `stringByteLength` tests when running on Node.js.
dsmilkov
approved these changes
Jul 5, 2018
There was a problem hiding this comment.
Nice work! I think this approach of feature testing if the way to go. Sorry for the delay in review!
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 LGTMs obtained
dsmilkov
approved these changes
Jul 5, 2018
complete! 1 of 1 LGTMs obtained
|
@ctemer That doesn't look related to this PR, does it? |
|
sorry misstyped |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix
arrayBufferToBase64StringandstringByteLengthtests when running on Node.js.Those tests are currently blacklisted with
tfjs-nodehere:https://github.com/tensorflow/tfjs-node/blob/master/src/run_tests.ts#L45-L46
Refs: tensorflow/tfjs#279
This change is