This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
use setImmediate instead of requestAnimationFrame on Node.js #1145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes
await tf.nextFrame();
work on Node.js for better code interoperability.It also does the expected thing of unblocking the event loop and giving the engine time to perform other tasks, though the name is a bit confusing.
The order of the check is important: IE and Edge also implement
setImmediate
, but all versions that do that also haverequestAnimationFrame
, sorequestAnimationFrame
is used on those.Refs: setImmediate, Node.js Event Loop.
For repository owners only:
Please remember to apply all applicable tags to your pull request.
Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY
For more info see: https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md
This change is