This repository has been archived by the owner on Aug 15, 2019. It is now read-only.
test_node: throw on unhandled promise rejections #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes `test-node` treat unhandled rejections as errors.
|
#1151 landed, I rebased this. Tests should pass now. |
dsmilkov
approved these changes
Jul 10, 2018
There was a problem hiding this comment.
This is excellent. Can you make the same change to https://github.com/tensorflow/tfjs-node/blob/master/src/run_tests.ts (another PR).
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 approvals obtained (waiting on @dsmilkov)
ChALkeR
added a commit
to ChALkeR/tfjs-node
that referenced
this pull request
Jul 10, 2018
This makes 'test' script treat unhandled rejections as errors. Refs: tensorflow/tfjs-core#1152 Refs: https://nodejs.org/api/process.html#process_event_unhandledrejection
nkreeger
pushed a commit
to tensorflow/tfjs-node
that referenced
this pull request
Jul 10, 2018
This makes 'test' script treat unhandled rejections as errors. Refs: tensorflow/tfjs-core#1152 Refs: https://nodejs.org/api/process.html#process_event_unhandledrejection <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/tensorflow/tfjs-node/118) <!-- Reviewable:end -->
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes
test-nodetreat unhandled rejections as errors.Refs: https://nodejs.org/api/process.html#process_event_unhandledrejection
For repository owners only:
Please remember to apply all applicable tags to your pull request.
Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY
For more info see: https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md
This change is