Fixed decodeWeights bug and added quntization support

[pyu10055]

Description

Fixed issue tensorflow/tfjs#591

---

For repository owners only:

Please remember to apply all applicable tags to your pull request.
Tags: FEATURE, BREAKING, BUG, PERF, DEV, DOC, SECURITY

For more info see: https://github.com/tensorflow/tfjs/blob/master/DEVELOPMENT.md

---

This change is 

[caisq]

Thanks for PR!

Reviewable status: 0 of 1 approvals obtained (waiting on @pyu10055 and @caisq)

---

src/io/io_utils.ts, line 91 at r1 (raw file):

${quantization.dtype}.

It would be good to say what the supported quantization dtypes are in this error message.

---

src/io/io_utils.ts, line 108 at r1 (raw file):

 quantization

This should be just 'dtype', not 'quantization dtype', right?

---

src/io/io_utils.ts, line 114 at r1 (raw file):

const byteBuffer = buffer.slice(offset, offset + size * dtypeFactor);

Thanks for fixing this. Can you add a unit test to cover the previously-failing cases?

[pyu10055]

Reviewable status: 0 of 1 approvals obtained (waiting on @caisq and @pyu10055)

---

src/io/io_utils.ts, line 91 at r1 (raw file):

Previously, caisq (Shanqing Cai) wrote…

${quantization.dtype}.

It would be good to say what the supported quantization dtypes are in this error message.

Done.

---

src/io/io_utils.ts, line 108 at r1 (raw file):

Previously, caisq (Shanqing Cai) wrote…

 quantization

This should be just 'dtype', not 'quantization dtype', right?

Done.

---

src/io/io_utils.ts, line 114 at r1 (raw file):

Previously, caisq (Shanqing Cai) wrote…

const byteBuffer = buffer.slice(offset, offset + size * dtypeFactor);

Thanks for fixing this. Can you add a unit test to cover the previously-failing cases?

the original tests have a mix type test, which I updated its bool data to be odd and failed the original code.

[caisq]

Reviewable status: 0 of 1 approvals obtained (waiting on @caisq)

---

src/io/io_utils.ts, line 108 at r1 (raw file):

Previously, pyu10055 (Ping Yu) wrote…

Done.

Ah - cool! Sorry I missed that subtle change.