Skip to content
This repository has been archived by the owner on Aug 15, 2019. It is now read-only.

Linalg qr #1255

Merged
merged 3 commits into from
Aug 28, 2018
Merged

Linalg qr #1255

merged 3 commits into from
Aug 28, 2018

Conversation

bileschi
Copy link
Contributor

@bileschi bileschi commented Aug 28, 2018

Description

DOC: Moves qr and gramSchmidt to under linalg namespace.

Adds code snips to both.


For repository owners only:

DOC: linalg namespace update.


This change is Reviewable

@bileschi
Copy link
Contributor Author

image

@bileschi
Copy link
Contributor Author

Fixes : tensorflow/tfjs#642

Copy link
Collaborator

@caisq caisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 approvals obtained (waiting on @bileschi, @caisq, and @dsmilkov)


src/ops/linalg_ops.ts, line 37 at r1 (raw file):

let y = tf.linalg.gramSchmidt(x);

Maybe do y.print() to show the result, in addition to the extra verification below.


src/ops/linalg_ops.ts, line 116 at r1 (raw file):

let [q, r] = tf.linalg.qr(a);

As above, do q.print() and r.print() to show the direct results.

Copy link
Contributor Author

@bileschi bileschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @caisq, @bileschi, and @dsmilkov)


src/ops/linalg_ops.ts, line 37 at r1 (raw file):

Previously, caisq (Shanqing Cai) wrote…
let y = tf.linalg.gramSchmidt(x);

Maybe do y.print() to show the result, in addition to the extra verification below.

done

@bileschi bileschi merged commit a660a54 into master Aug 28, 2018
@dsmilkov dsmilkov deleted the linalg_qr branch November 20, 2018 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants